Update minimum Python version to 3.7.2 #6926
Conversation
datumbox
added
module: documentation
other
datumbox
changed the title
| | ``main`` / ``nightly`` | ``main`` / ``nightly`` | ``>=3.7.2``, ``<=3.10`` | | ||
| +--------------------------+--------------------------+---------------------------------+ | ||
| | ``1.13.0`` | ``0.14.0`` | ``>=3.7``, ``<=3.10`` | | ||
| | ``1.13.0`` | ``0.14.0`` | ``>=3.7.2``, ``<=3.10`` | |
There was a problem hiding this comment.
Thanks @datumbox . Are we planning on a bugfix release soon? Otherwise it might be more accurate to leave this line untouched (and update the X in 0.14.X)
There was a problem hiding this comment.
I am not aware of any bugfix releases any time soon. I think we should update the table to reflect that 3.7.0 won't work.
| }, | ||
| ext_modules=get_extensions(), | ||
| python_requires=">=3.7", | ||
| python_requires=">=3.7.2", |
There was a problem hiding this comment.
As I commented on #6925 (comment), I think there might be a more robust and future-proof way of handling the original failure.
I'm also wondering if it's safe for us to deviate from torch core's Python version requirements which seem to be set to 3.7.0 as well:
@malfet could you please advise on this?
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM. Please note, that in general we should be supporting newest patch revision
|
@malfet thanks for your input. Does that mean torch core and all other domain libraries need to update their Python lower bound? |
|
@NicolasHug yes, but currently there is no good way to say, that we want to support say >=3.7.10, >=3.8.6, >=3.9.10 etc See some discussion when similar |
Reviewed By: NicolasHug Differential Revision: D41265201 fbshipit-source-id: e4d2e82beb296a8e3b7a2e395478f02fcf10773d
4 participants
Related to #6925