Update transforms.py #213
Update transforms.py #213
Conversation
Adding different types of padding: symmetric, edge, reflect
alykhantejani
left a comment
alykhantejani
left a comment
There was a problem hiding this comment.
I've left some inline comments, as a general comment though - do we want to add separate transforms for these (MirrorPad, SymetricPad etc.)?
| assert (type in ["constant","edge","symmetric","reflect"]) | ||
| self.type = type | ||
|
|
||
| def __expand_reflect(slef,image, border=0): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| assert isinstance(fill, numbers.Number) or isinstance(fill, str) or isinstance(fill, tuple) | ||
| self.padding = padding | ||
| self.fill = fill | ||
| assert (type in ["constant","edge","symmetric","reflect"]) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| scale = Scale(self.size, interpolation=self.interpolation) | ||
| crop = CenterCrop(self.size) | ||
| return crop(scale(img)) | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| import types | ||
| import collections | ||
|
|
||
| import functools |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| """ | ||
|
|
||
| def __init__(self, padding, fill=0): | ||
| def __init__(self, padding, fill=0,type="constant"): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Also, we should add some tests for these new pad variants. |
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay in replying.
I agree with @alykhantejani comments, and also made some more. Could you look into addressing those issues?
| :return: An image. | ||
| """ | ||
| img = np.asarray(image) | ||
| img = np.pad(img, pad_width=border, mode="reflect") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| """ | ||
| img = np.asarray(image) | ||
| img = np.pad(img, pad_width=border, mode="reflect") | ||
| return Image.fromarray(np.uint8(img)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return ImageOps.expand(img, border=self.padding, fill=self.fill) | ||
| if self.type == "constant": | ||
| return ImageOps.expand(img, border=self.padding, fill=self.fill) | ||
| elif self.type == "symmetric": |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Superseded by #460 |
3 participants
Adding different types of padding: symmetric, edge, reflect