Added pytest.mark.xfail on test_distrib_gloo_cpu_or_gpu()#2454
Merged
vfdev-5 merged 6 commits intopytorch:masterfrom Feb 8, 2022
nishantb06:master
Merged
Added pytest.mark.xfail on test_distrib_gloo_cpu_or_gpu()#2454vfdev-5 merged 6 commits intopytorch:masterfrom nishantb06:master
vfdev-5 merged 6 commits intopytorch:masterfrom
nishantb06:master
Conversation
Collaborator
|
@nishantb06 thanks for the PR, let's xfail all tests in this python file.
|
Collaborator
|
@nishantb06 thanks for the update, I added manually 2 more xfails to disable all the tests and also restart CI. Let's see if it passes now and we can merge this PR. |
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2453
Description:
After correcting the syntax of
pytest.approx(), Assertion error was detected due to the values not being the same. Which is whypytest.mark.xfailwas added ontest_distrib_gloo_cpu_or_gpu()Check list: