fix(search): bump @docsearch/js to 3.3 & add appId in config#159
Merged
fix(search): bump @docsearch/js to 3.3 & add appId in config#159
appId in config#159Conversation
✅ Deploy Preview for pytorch-ignite ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jeffydc
changed the title
appId in configappId in config
Member
|
@ydcjeff thanks for the PR ! |
added 14 commits
November 11, 2022 20:13
jeffydc
force-pushed
the
fix/algolia-search
branch
from
51af881 to
a596165
Compare
Collaborator
Author
|
|
jeffydc
changed the title
appId in configappId in config
Collaborator
Author
|
@vfdev-5 the submodule failure is fixed in this PR and netlify failure is not updated in the check although the site is built successfully. https://deploy-preview-159--pytorch-ignite.netlify.app/ |
Member
|
@ydcjeff can we merge this PR ? |
Collaborator
Author
|
@vfdev-5 yes, it's ready. |
jeffydc
pushed a commit
that referenced
this pull request
Dec 30, 2022
Follow up of #159 , I forgot to update the css version.
vfdev-5
pushed a commit
that referenced
this pull request
Jan 5, 2023
Follow up of #159 , I forgot to update the css version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algolia docsearch has moved to new version and let admins directly edit the config via their web interface. So we need to update the docsearch version we are using to the latest stable one as well.