Skip to content

fix: re-save with jupyter lab to bump nbformat#83

Merged
vfdev-5 merged 1 commit intomainfrom
bump-nbformat
Nov 12, 2022
Merged

fix: re-save with jupyter lab to bump nbformat#83
vfdev-5 merged 1 commit intomainfrom
bump-nbformat

Conversation

@jeffydc
Copy link
Collaborator

@jeffydc jeffydc commented Nov 11, 2022

The diff is a little hard to review. This PR would unblock the submodule workflow in website repo.

To verify this PR,

  1. open a new env with GitHub Codespaces.
  2. Run pip install nbformat
  3. Run jupyter nbconvert --to markdown 'how-to-guides/*.ipynb' --output-dir output --NbConvertApp.output_files_dir $(pwd)/static/_images/
  4. Similar command for tutorials as well
  5. nbconvert can successfully convert notebook to markdown

Copy link
Member

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ydcjeff !

@jeffydc
Copy link
Collaborator Author

jeffydc commented Nov 12, 2022

@vfdev-5 I can't merge the PR.

@vfdev-5 vfdev-5 merged commit f2278eb into main Nov 12, 2022
@vfdev-5 vfdev-5 deleted the bump-nbformat branch November 12, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants