dependency: harmonize string representation#393
Merged
neersighted merged 1 commit intopython-poetry:mainfrom Jun 6, 2022
Merged
Conversation
radoering
force-pushed
the
harmonize-dependency-str-representation
branch
from
a5c1144 to
9123a8e
Compare
neersighted
approved these changes
Jun 5, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #103
Dependency.__str__has been changed to returnbase_pep_508_name. Each sub class ofDependencystill has its own (inconsistent)__str__implementation. For example extras are not included, which can be confusing/annoying. Further,URLDependencydoes not even include the url but only hard-coded "url".I was thinking about only returning
base_pep_508_name, but that does not include the constraint for direct origin dependencies and thus makes debugging more difficult. Since__str__is especially used in (debug) prints, it should be ok not to return a PEP 508 compliant string. (At least, we didn't do that before.) Thus,base_pep_508_nameenriched with constraint is returned. That way, we can avoid multiple implementations and still have all relevant information.