preserver marker order at union#383
Merged
neersighted merged 1 commit intopython-poetry:mainfrom May 30, 2022
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
neersighted
approved these changes
May 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








per python-poetry/poetry#5721, use of a set made the representation of markers non-deterministic.
A set is really the appropriate data structure, and this change is a bit of an uglification. But the number of elements in a marker union is very rarely going to be more than, say, 5 - so I doubt that efficiency is an issue.
An alternative that I considered was to try and impose an ordering in the
__str__, but:I also decided that unit test wasn't very useful: a regression in the exact same way doesn't seem very likely. Can add the testcase from python-poetry/poetry#5721 if anyone thinks it's worth the trouble