Removing MSVC C4100 from pragma block at the top of pybind11.h #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
force-pushed
the
pragma_block_rm_msvc_c4100
branch
from
e89b2ec to
85dd61c
Compare
rwgk
changed the title
henryiii
reviewed
Jul 28, 2021
henryiii
reviewed
Jul 28, 2021
henryiii
approved these changes
Jul 28, 2021
Collaborator
Author
|
Thanks Henry! (Only two more MSVC pragmas to go.) |
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jul 29, 2021
rwgk
added a commit
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to PR #3127, based on results obtained under PR #3125.
The suggested changelog entry will be in the final PR of this cleanup series.
Worksheet