-
Notifications
You must be signed in to change notification settings - Fork 2.3k
WIP: pragma block reduction #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0089c6d to
9b335de
Compare
d2a7663 to
e7b7352
Compare
This was referenced Jul 17, 2021
This was referenced Jul 25, 2021
Merged
This was referenced Aug 2, 2021
Collaborator
Author
|
This work was completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spreadsheet: pybind11.h v2.7.0 pragma block analysis
Approach:
Keeping track of some simple results here:
-Wunused-but-set-parameterneeds work-Wunused-but-set-variablerm_ok-Wmissing-field-initializersrm_ok-Wattributesneeds work-Wnoexcept-typeneeds work (gcc 7 only)C4100needs workC4127needs workC4512rm_okC4800needs workC4996needs workC4702rm_okC4522needs workC4505needs work186rm_ok878needs work1334rm_ok1682rm_ok1786rm_ok1875rm_ok2196needs work