Skip to content

Conversation

@henryiii
Copy link
Collaborator

The Conda-forge package is reporting the wrong directory. From local testing, the standard way of accessing the directory seems to be working correctly; it's just the injected special logic that is causing issues.

Is the virtualenv logic needed, or could it be removed as well?

Testing this in Conda-forge before making the PR non-draft.

@henryiii
Copy link
Collaborator Author

This fixed the problem with Conda here: conda-forge/pybind11-feedstock#43

@henryiii
Copy link
Collaborator Author

The failure with CI is due to a ruby error in homebrew, and is unrelated.

@henryiii
Copy link
Collaborator Author

henryiii commented Jan 15, 2020

The thing I have not tested is that if a pip install in a conda environment works properly with this change.

Edit: Yes, it seems to report correctly.

@henryiii henryiii marked this pull request as ready for review January 15, 2020 21:06
@ax3l
Copy link
Collaborator

ax3l commented Jan 16, 2020

Thank you for the report.

As added here, I cannot reproduce the problem with conda (on conda-forge) that you report and this diff likely breaks the includes.

Also note that upcoming releases got again a logic change in #1995 - maybe you are mismatching versions between development and latest stable with corresponding install logic locally? Maybe you are mixing a homebrew install with a local conda install to build upon?

@henryiii
Copy link
Collaborator Author

henryiii commented Jan 16, 2020

Yes, this is targeted at stable (which I didn't notice), it may be fixed in master.

@henryiii henryiii changed the title Fix conda include reporting Fix conda include reporting [do not merge] Jan 16, 2020
@ax3l
Copy link
Collaborator

ax3l commented Jan 18, 2020

Got it, it's a conda-forge, Unix-only install problem since we passed a contradicting flag to CMake.
Fix proposed in conda-forge/pybind11-feedstock#44

Thank you for spotting this! ✨

@wjakob
Copy link
Member

wjakob commented Jun 30, 2020

The logic in __init__.py has changed quite a bit in the meantime, and conda-forge/pybind11-feedstock#44 landed. Can this be closed?

@henryiii
Copy link
Collaborator Author

henryiii commented Jul 1, 2020

I think so. I'll open an issue if anything is still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants