Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Jan 18, 2020

Add a check that the path is not only where we want it but files also exist.

Added without logic change to current builds (Re: #43).
Thanks to @henryiii for reporting this! ✨

cc @sdebionne you might want to take a look at this (Re: #32)

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ax3l ax3l changed the title meta: add include file existance check meta: add include file existence check Jan 18, 2020
@ax3l ax3l mentioned this pull request Jan 18, 2020
4 tasks
@ax3l ax3l changed the title meta: add include file existence check Unix: Fix Broken Include (& Add Test) Jan 18, 2020
@ax3l ax3l added the bug label Jan 18, 2020
@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2020

ping @wjakob @SylvainCorlay: this conda-forge bugfix for Unix builds is ready to be reviewed & merged.

@henryiii
Copy link
Contributor

Master should be checked before the next release to make sure it's still working (after this is merged).

@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2020

Yes, this will automatically be checked when it goes through here.

@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2020

(Just amended the meta-data of the last commit to put authorship on you, since I did not see initially that you also changed that line in #43. Sorry again for this.)

Add a check that the path is not only where we want it but files also
exist.
@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2020

@conda-forge-admin, please rerender

@ax3l
Copy link
Member Author

ax3l commented Jan 18, 2020

Excellent, now that it's your code I can review and merge it myself :-p
Jokes aside, thanks again :)

@ax3l ax3l merged commit a26612c into conda-forge:master Jan 18, 2020
@ax3l ax3l deleted the fix-includePath branch January 18, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants