Skip to content

BUG: Do not fail on choice field without /Opt key #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan6419846 merged 4 commits into from
Dec 1, 2025
Merged

BUG: Do not fail on choice field without /Opt key #3540

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9e3793
TST: Add a testcase for a choice field without /Opt key
jhuber-de Nov 29, 2025
9ba8a4f
BUG: Fix reading of choice fields missing the /Opt key
jhuber-de Nov 29, 2025
bc5f374
TST: Refactor unittest to use PDF from github comment instead of loca…
jhuber-de Dec 1, 2025
4710d78
TST: Add missing newline in test_reader.py
jhuber-de Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pypdf/_doc_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ def _build_field(
fileobj.write("\n")
retval[key] = Field(field)
obj = retval[key].indirect_reference.get_object() # to get the full object
if obj.get(FA.FT, "") == "/Ch":
if obj.get(FA.FT, "") == "/Ch" and obj.get(NameObject(FA.Opt)):
retval[key][NameObject("/_States_")] = obj[NameObject(FA.Opt)]
if obj.get(FA.FT, "") == "/Btn" and "/AP" in obj:
# Checkbox
Expand Down
16 changes: 15 additions & 1 deletion tests/test_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def test_get_page_of_encrypted_file(pdffile, password, should_fail):
"crazyones.pdf",
{},
None,
),
)
],
)
def test_get_form(src, expected, expected_get_fields, txt_file_path):
Expand Down Expand Up @@ -447,6 +447,20 @@ def test_get_form(src, expected, expected_get_fields, txt_file_path):
field.additional_actions,
]

@pytest.mark.enable_socket
def test_reading_choice_field_without_opt_key():
"""Tests reading a choice field in a PDF without an /Opt key."""
url = "https://github.com/user-attachments/files/23853677/Musterservicevertrag-HNRAGB_Okt2022-Blanko.pdf"
reader = PdfReader(BytesIO(get_data_from_url(url, name="Musterservicevertrag-HNRAGB_Okt2022-Blanko.pdf")))
fields = reader.get_fields()

tn_anrede = fields.get("TN_Anrede")
assert tn_anrede is not None

# Ensure that parsing of a choice field without /Opt key worked
tn_anrede_opt = tn_anrede.get("/Opt")
assert tn_anrede_opt is None


@pytest.mark.parametrize(
("src", "page_number"),
Expand Down
Loading