-
Notifications
You must be signed in to change notification settings - Fork 1.5k
BUG: Do not fail on choice field without /Opt key #3540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Do not fail on choice field without /Opt key #3540
Conversation
Closes py-pdf#2838 According to the PDF 2.0 specification, the `/Opt` key is not required for choice fields
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3540 +/- ##
==========================================
- Coverage 97.16% 97.16% -0.01%
==========================================
Files 57 57
Lines 9809 9808 -1
Branches 1781 1781
==========================================
- Hits 9531 9530 -1
Misses 167 167
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For these cases, we regularly use a local copy downloaded from a GitHub comment link as we cannot safely ship the file with pypdf directly in these cases. Feel free to use the following link: Musterservicevertrag-HNRAGB_Okt2022-Blanko.pdf |
stefan6419846
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
## What's new ### Performance Improvements (PI) - Optimize loop for layout mode text extraction (#3543) by @FelipeErmeson ### Bug Fixes (BUG) - Do not fail on choice field without /Opt key (#3540) by @jhuber-de ### Documentation (DOC) - Document possible issues with merge_page and clipping (#3546) by @stefan6419846 - Add some notes about library security (#3545) by @stefan6419846 ### Maintenance (MAINT) - Use CORE_FONT_METRICS for widths where possible (#3526) by @PJBrs [Full Changelog](6.4.0...6.4.1)
This PR fixes a issue (#2838) with reading of choice fields that are missing the optinal
/Optkey.