Fix implicit cast of enum-type #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
BUMP. PLS MERGE. I HAVE NO PATIENCE OR SELF CONTROL, PLS DO JOB. |
11 tasks
thommythomaso
force-pushed
the
phsauter/slang
branch
4 times, most recently
from
b48771b to
5f205ee
Compare
store_req_t is a parameter coming from above, it contains tag_mode_e. This leads to an error in slang flagging the implicit cast: > error: no implicit conversion from 'bit[0:0]' to 'tag_mode_e'; > explicit conversion exists, are you missing a cast? If we just assign a casted zero-vector this is prevented.
thommythomaso
force-pushed
the
phsauter/slang
branch
from
5f205ee to
2083ff8
Compare
thommythomaso
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store_req_t is a parameter coming from above, it contains tag_mode_e. This leads to an error in slang flagging the implicit cast:
If we just assign a casted zero-vector this is prevented.