Custom insert popover problem Solved #794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Collaborator
|
Hey @RaviAnand111 well done! |
NARUDESIGNS
reviewed
Jan 18, 2022
dist/PublicLab.Editor.js
Outdated
| $(':not(".woofmark-command-insert")').click((e) => { | ||
| // check to see that the clicked element isn't fa-insert icon, else when you click on the fa-insert icon, the popover will close | ||
| try { | ||
| if ($('.woofmark-command-insert').children()[0] != e.target) { |
Collaborator
There was a problem hiding this comment.
I think you should also check if the popover is open here by adding
+ if (popoverIsOpen && $('.woofmark-command-insert').children()[0] != e.target) {this way, you don't need a try/catch block @RaviAnand111
Contributor
Author
There was a problem hiding this comment.
Oh, Ok I will be adding that in the code, Thanks
Contributor
Author
|
Yeah, @NARUDESIGNS , Its late here, I have to go to sleep, I will be making those demo videos in the morning and adding it in this PR and the preivous one too, so that you and @TildaDares can review it. |
Contributor
Author
multiple-popover-bug.mp4Hey @NARUDESIGNS @TildaDares @jywarren , I have added a demo video, you can check out the changes before and after adding the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750
fixes #793
This is a PR for the multiple popover problem, all the popover buttons are being solved and committed in different PRs, as I have been told, every different changes should be made in different PRs,
You can review the code
@NARUDESIGNS @TildaDares
Thank You