Skip to content

Conversation

@RaviAnand111
Copy link
Contributor

fixes#752

Hey, @NARUDESIGNS @TildaDares can you review the PR please ?

@gitpod-io
Copy link

gitpod-io bot commented Dec 29, 2021

@NARUDESIGNS
Copy link
Collaborator

For your last 2 commits, I still see your formatter added lots of changes. @RaviAnand111

@RaviAnand111
Copy link
Contributor Author

Sorry about that, I will rectify it ASAP.

@RaviAnand111
Copy link
Contributor Author

Can you check it now please

@TildaDares
Copy link
Member

Hi @RaviAnand111, the changes made by your formatter are still there. You can also check it yourself by clicking on the Files changed tab on this PR page. It shows a list of all the changes you made to each file. Thanks!

@TildaDares
Copy link
Member

@RaviAnand111 Since the change you added is a one-liner, you can replace the contents of your local file with the contents of the remote Public Lab repo and then add your changes again.

@TildaDares
Copy link
Member

Hi @RaviAnand111, have you disabled your linter/formatter?

@TildaDares
Copy link
Member

@RaviAnand111 What IDE/text editor do you use?

@RaviAnand111
Copy link
Contributor Author

VS code
I had prettier enabled, but I disabled it.
I also disabled format on save setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants