Skip to content

Conversation

@RaviAnand111
Copy link
Contributor

PR #768

Hey @TildaDares @NARUDESIGNS , I created this new PR, Can you review it for me please, I know, I am making so many mistakes, Sorry, I get confused sometimes,
ThankYou for helping me all the time

@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2021

@RaviAnand111
Copy link
Contributor Author

Should I close the previous PR #768 ?

@TildaDares
Copy link
Member

@RaviAnand111 Yes you can close the other PR. Thanks!

@TildaDares TildaDares linked an issue Dec 30, 2021 that may be closed by this pull request
@TildaDares
Copy link
Member

@RaviAnand111 It was the same when I first started contributing so you don't have to worry about making mistakes, we're here to help you.

@RaviAnand111
Copy link
Contributor Author

ThankYou ❤️ 🔥 🎉

@NARUDESIGNS
Copy link
Collaborator

@RaviAnand111 It was the same when I first started contributing so you don't have to worry about making mistakes, we're here to help you.

Yea, me too and @TildaDares was (and still is) able to guide me through some of the problems. That's the thing about open source, you get support and you get to learn too.

@TildaDares
Copy link
Member

@RaviAnand111 Can you add a screenshot of the UI changes? Thanks!

@RaviAnand111
Copy link
Contributor Author

Here you go,
closer look
image

broader look
image

@TildaDares TildaDares requested a review from NARUDESIGNS January 3, 2022 16:51
@TildaDares
Copy link
Member

I'll leave the review for @NARUDESIGNS since this issue is a part of his project.

Great job @RaviAnand111!

@RaviAnand111
Copy link
Contributor Author

ThankYou @TildaDares 🎉 ❤️

@NARUDESIGNS
Copy link
Collaborator

@RaviAnand111 Looks great!
Good job sir!
cc @TildaDares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table popover button content not visible on hover.

3 participants