Skip to content

Just an experiment (do not merge)#35

Closed
mpizenberg wants to merge 21 commits intodevfrom
ci-docker
Closed

Just an experiment (do not merge)#35
mpizenberg wants to merge 21 commits intodevfrom
ci-docker

Conversation

@mpizenberg
Copy link
Copy Markdown
Member

No description provided.

@aleksator
Copy link
Copy Markdown
Member

Hi @mpizenberg! I wonder what was the reason for ci: remove usage of cargo version for cache?
Should I remove it from #31?

@aleksator
Copy link
Copy Markdown
Member

By the way, instead of ci: retry you can rerun any pipeline from Actions link on top.

@aleksator
Copy link
Copy Markdown
Member

Hi @mpizenberg! I wonder what was the reason for ci: remove usage of cargo version for cache?
Should I remove it from #31?

Ah, maybe it just wasn't working with the ash shell.

@mpizenberg
Copy link
Copy Markdown
Member Author

Hi @mpizenberg! I wonder what was the reason for ci: remove usage of cargo version for cache?
Should I remove it from #31?

oh no don't worry, that's because I initially tried with the alpine image which is lighter but the command for that required bash

@aleksator
Copy link
Copy Markdown
Member

oh no don't worry, that's because I initially tried with the alpine image which is lighter but the command for that required bash

I like the idea of using docker container that already has the latest Rust version installed. I knew it was possible in Gitlab, but haven't seen the option here.

Looking closer, it still has to be downloaded rather than being a base for the runner, huh. Might not provide any network savings that way at all...

I wonder if we could use someone else's image for runs-on (custom runner) that we wouldn't have to maintain ourselves. Haven't seen that in the wild yet though.

@mpizenberg
Copy link
Copy Markdown
Member Author

Looking closer, it still has to be downloaded rather than being a base for the runner, huh. Might not provide any network savings that way at all...

Yes, I rerun it to see if it would have to download again the image and it appears it did. Too bad the image is not kept in the runner cache.

@aleksator
Copy link
Copy Markdown
Member

Yes, I rerun it to see if it would have to download again the image and it appears it did. Too bad the image is not kept in the runner cache.

Yeah, a runner is a brand new VM for every job.

@mpizenberg
Copy link
Copy Markdown
Member Author

No need to keep that around. We can come back to it if needed in the closed PRs. It has served its experimental purpose.

@mpizenberg mpizenberg closed this Oct 17, 2020
konstin pushed a commit that referenced this pull request Dec 12, 2024
…#35)

## Summary

This PR borrows a trick from
[HashMap](https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.contains_key)
to enable users to pass (e.g.) `&str` to `Ranges::contains`, given
`Ranges<String>`.
konstin pushed a commit that referenced this pull request Dec 20, 2024
…#35)

## Summary

This PR borrows a trick from
[HashMap](https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.contains_key)
to enable users to pass (e.g.) `&str` to `Ranges::contains`, given
`Ranges<String>`.
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
…#35) (#301)

## Summary

This PR borrows a trick from
[HashMap](https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.contains_key)
to enable users to pass (e.g.) `&str` to `Ranges::contains`, given
`Ranges<String>`.

Co-authored-by: Charlie Marsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants