-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Various CI and doc refactors #4928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
a216316 to
7aa9f3a
Compare
21df0e8 to
68b2798
Compare
68b2798 to
5a81189
Compare
…ctness Signed-off-by: cobalt <[email protected]>
Use them most places (some places are migrated in future commits) Also bumps some action runner versions And updates dependabot/pre-commit config to check for more updates Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
Most notably: - vim files (and Python heredocs) - Sphinx attestations - pyproject.toml Signed-off-by: cobalt <[email protected]>
- Standardize `/py(thon)?(3)?/` to `python` - Only use `console` when output is shown, because it's very lacking compared to `sh` - Add a few other missing languages Signed-off-by: cobalt <[email protected]>
Signed-off-by: cobalt <[email protected]>
Cuts build times from ~45 to ~6 minutes
Reword PR comment to be clearer and more detailed Work around Prettier format issues Update docs appropriately Signed-off-by: cobalt <[email protected]>
|
All issues have been fixed, ready for review! |
hauntsaninja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good from a skim! (And happy new year! :-) )
| ```python | ||
| def f( | ||
| ): | ||
| "Make sure this code is blackened""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "current Black style" needs to be Blackened, but the proposed desired style can be anything (also preexisting, but the triple quotes are mismatched :-) )
Maybe "This code should be formatted as per the current Black style" would be clearer
| First clone the _Black_ repository: | ||
|
|
||
| ```console | ||
| ```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this syntax highlight well, given that we include the PS1 prompt?
Description
Various unrelated refactors, most of which are too small for their own PR
Since most changes are largely unrelated, it may be easier to review this PR commit-by-commit, so I made sure to keep each change contained to a single commit and I've listed them here:
pyproject.tomlpathsmatchers on action triggersifchecks (see Upgrade PyPI upload workflow to use Trusted Publishing (#4589) #4611 (comment))stablebranch on prereleases, which doesn't currently work anyway and just causes the workflow to "fail"/py(thon)?(3)?/topythonconsolewhen output is shown, because it's very lacking compared toshworkflow_runtrigger unfortunately (see Lingering CI/CD pins, add cooldowns, remove template injections #4906); there's no way to comment on the PR without itall CI changes were tested as best I could
Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?