-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Lingering CI/CD pins, add cooldowns, remove template injections #4906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: William Woodruff <[email protected]>
| cooldown: | ||
| default-days: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this and below prevents Dependabot from sending update PRs for dependency updates that are less than 7 days old. You can tweak this number (or I can remove it entirely), but I'd recommend some degree of "cooldown" since it's currently effective against the kinds of package compromises that have become increasingly common: https://blog.yossarian.net/2025/11/21/We-should-all-be-using-dependency-cooldowns
|
Thanks so much! I'd accept a PR adding zizmor to CI. As for the remaining workflow_run issue, looks like it's https://github.com/psf/black/blob/main/.github/workflows/diff_shades_comment.yml . We'd have to talk about how to handle it; maybe it's fine to restrict the capabilities of the workflow in some way. |
No longer uses `workflow_run` trigger (see psf#4906) Reword PR comment to be clearer and more detailed Work around Prettier format issues Update docs appropriately Signed-off-by: cobalt <[email protected]>
No longer uses `workflow_run` trigger (see psf#4906) Reword PR comment to be clearer and more detailed Work around Prettier format issues Update docs appropriately Signed-off-by: cobalt <[email protected]>
No longer uses `workflow_run` trigger (see psf#4906) Reword PR comment to be clearer and more detailed Work around Prettier format issues Update docs appropriately Signed-off-by: cobalt <[email protected]>
…4906) Signed-off-by: William Woodruff <[email protected]>
Description
This follows #4901 and #4905 with some more small CI/CD security improvements. It hash-pins some of the dependencies added with #4611, minimizes more workflow/job permissions, and eliminates a few template injections (which probably aren't exploitable in practice in this context, but are still good to remove IMO!)
Following this, there's only one finding left from zizmor (which will unfortunately be nontrivial to fix, since it involves a
workflow_runtrigger). I'm happy to try and take a look at that, but the "fix" might be a removal of functionality so I'll file an issue for consultation first.Separately, I'm happy to send a PR enabling zizmor in your CI, either through pre-commit or zizmor-action. Let me know if either of these would be helpful; there's plenty of PSF / PyPA / PyPI / etc. reference material I can share for others using it!
Checklist - did you ...
--previewstyle, following thestability policy?
CHANGES.mdif necessary?Like with the other PRs, I think none of the above apply 🙂