Skip to content

Bump peter-evans/find-comment from 2.1.0 to 2.2.0 #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Dec 29, 2022
Merged

Bump peter-evans/find-comment from 2.1.0 to 2.2.0 #3476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/diff_shades_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Try to find pre-existing PR comment
if: steps.metadata.outputs.needs-comment == 'true'
id: find-comment
uses: peter-evans/find-comment@f4499a714d59013c74a08789b48abe4b704364a0
uses: peter-evans/find-comment@81e2da3af01c92f83cb927cf3ace0e085617c556
Copy link
Collaborator

@cooperlees cooperlees Dec 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we or should we move to release tags? Anyone remember why we on commit hashes?

https://github.com/peter-evans/find-comment/releases/tag/v2.2.0

Copy link
Collaborator

@ichard26 ichard26 Dec 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security, SHAs are immutable so even if some bad actor gains access and updates a tag to contain malicious code, it would take an upgrade on our side to pull it in. It doesn't really make any sense though since it's unlikely we'd do an comprehensive audit of the line changes committed since the old version.

Copy link
Collaborator

@JelleZijlstra JelleZijlstra Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safer to keep using commit hashes since an attacker could modify the tag, and this would take effect immediately unlike a release.

with:
issue-number: ${{ steps.metadata.outputs.pr-number }}
comment-author: "github-actions[bot]"
Expand Down