Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 26, 2022

Bumps peter-evans/find-comment from 2.1.0 to 2.2.0.

Release notes

Sourced from peter-evans/find-comment's releases.

Find Comment v2.2.0

What's Changed

New Contributors

Full Changelog: peter-evans/find-comment@v2.1.0...v2.2.0

Commits
  • 81e2da3 ci: add workflow
  • c21051d build: update distribution (#89)
  • dea9995 Add "comment-created-at" as output (#88)
  • 79dc7b4 Update dependabot.yml
  • 5c4d3db build: update distribution (#87)
  • df681b8 build(deps-dev): bump @​vercel/ncc from 0.32.0 to 0.36.0 (#85)
  • 64795f5 build(deps-dev): bump eslint from 8.3.0 to 8.29.0 (#83)
  • ce8872b build(deps-dev): bump typescript from 4.5.2 to 4.9.4 (#84)
  • 9a622f4 build(deps-dev): bump prettier from 2.5.0 to 2.8.1 (#86)
  • 757ed29 build(deps-dev): bump eslint-plugin-jest from 25.3.0 to 27.1.6 (#82)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [peter-evans/find-comment](https://github.com/peter-evans/find-comment) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/peter-evans/find-comment/releases)
- [Commits](peter-evans/find-comment@f4499a7...81e2da3)

---
updated-dependencies:
- dependency-name: peter-evans/find-comment
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added C: dependencies skip news Pull requests that don't need a changelog entry. labels Dec 26, 2022
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (97728af) to main (9b91638).


What is this? | Workflow run | diff-shades documentation

if: steps.metadata.outputs.needs-comment == 'true'
id: find-comment
uses: peter-evans/find-comment@f4499a714d59013c74a08789b48abe4b704364a0
uses: peter-evans/find-comment@81e2da3af01c92f83cb927cf3ace0e085617c556
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we or should we move to release tags? Anyone remember why we on commit hashes?

https://github.com/peter-evans/find-comment/releases/tag/v2.2.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security, SHAs are immutable so even if some bad actor gains access and updates a tag to contain malicious code, it would take an upgrade on our side to pull it in. It doesn't really make any sense though since it's unlikely we'd do an comprehensive audit of the line changes committed since the old version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safer to keep using commit hashes since an attacker could modify the tag, and this would take effect immediately unlike a release.

@JelleZijlstra JelleZijlstra merged commit 0abe85e into main Dec 29, 2022
@JelleZijlstra JelleZijlstra deleted the dependabot/github_actions/peter-evans/find-comment-2.2.0 branch December 29, 2022 22:00
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
Bumps [peter-evans/find-comment](https://github.com/peter-evans/find-comment) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/peter-evans/find-comment/releases)
- [Commits](peter-evans/find-comment@f4499a7...81e2da3)

---
updated-dependencies:
- dependency-name: peter-evans/find-comment
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: dependencies skip news Pull requests that don't need a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants