forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 2
Prov: Improve performance of GetAllBalances and GetAccountsBalances. #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I ran the following
|
arnabmitra
approved these changes
Mar 26, 2025
arnabmitra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lgtm:
SpicyLemon
added a commit
that referenced
this pull request
Apr 4, 2025
…616) * Improve performance of GetAllBalances and GetAccountsBalances. * Add changelog entry.
SpicyLemon
added a commit
that referenced
this pull request
Jul 15, 2025
* Remove the fee handler customization since the SDK added a post handler that does pretty much the same thing. * Make DefaultGasLimit a variable instead of constant. * Fix the post handler response code thing. * Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614) * build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <[email protected]> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <[email protected]> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <[email protected]> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <[email protected]> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Mark v0.50.12-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Zachary Becker <[email protected]> * Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#616) * Improve performance of GetAllBalances and GetAccountsBalances. * Add changelog entry. * Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615) * Merge commit from fork * Fix ABS061 * Use typed event * Add changelog * Review feedback * Check for events * Review feedback * Remove unecessary code comments * Set release date * fix changelog --------- Co-authored-by: Alex | Interchain Labs <[email protected]> * Add changelog entry. * Put nothing back at the top of the changelog. --------- Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]> * Add a bunch of logging. * Revert "Add a bunch of logging." This reverts commit 3baf4d3. * Make the DefaultGasLimit a constant again (back to how the SDK has it). * Add changelog entry. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Zachary Becker <[email protected]> Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the performance of GetAllBalances and GetAccountsBalances.
This is similar to cosmos#24148, but is being pulled into our fork because we need it sooner. Once we're basing our fork on a version that has that PR in it, we can remove this customization.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change