Skip to content

Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SpicyLemon merged 169 commits into from
Feb 20, 2025
Merged

Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. #614

SpicyLemon merged 169 commits into from
Feb 20, 2025

Conversation

@SpicyLemon
Copy link

@SpicyLemon SpicyLemon commented Feb 20, 2025 •
edited
Loading

Description

This PR will bring our v0.50.x branch in-line with SDK v0.50.12.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

mergify bot and others added 30 commits March 14, 2024 02:59
@mergify @rootulp @sontrinh16
fix(crypto): error if incorrect ledger public key (backport cosmos#19691
b8659ae 
) (cosmos#19745)

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>
@dependabot @github-actions
build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (c…
6977c22 
…osmos#19751)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @mmsqe @tac0turtle
fix: align signer extraction adapter for mempool remove (backport cos…
9a59234 
…mos#19759) (cosmos#19773)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
@mergify @gibson042 @tac0turtle
fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#1…
0df2902 
…9706) (cosmos#19767)

Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
@mergify @julienrbrt
fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#1…
1ad7fad 
…9777)

Co-authored-by: Julien Robert <[email protected]>
@dependabot @github-actions
@cool-develope @tac0turtle @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (…
ff30f6e 
…cosmos#19770)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cool Developer <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@tac0turtle
chore(store): add release date (cosmos#19797)
a6c7aa5
@dependabot @github-actions
build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (c…
87ad797 
…osmos#19811)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @akaladarshi
@tac0turtle @julienrbrt
feat(x/gov): emit proposer address in submit proposal event (backport c…
a0faab3 
…osmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @duvbell @julienrbrt
feat(x/gov): emit depositor in proposal_deposit event (backport cos…
9c53142 
…mos#19853) (cosmos#19859)

Co-authored-by: Kien <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
reuse fromAddrString (minor cleanup) (cosmos#19881)
d78edac
@mergify
feat(client): replace event-query-tx-for with wait-tx (backport c…
8641cd2 
…osmos#19870) (cosmos#19887)
@mergify @julienrbrt
feat(server): add custom start handler (backport cosmos#19854) (cosmo…
7b35e36 
…s#19884)

Co-authored-by: Julien Robert <[email protected]>
@dependabot @github-actions
@tac0turtle @julienrbrt
build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)
405471b 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify
docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (c…
f63e5fd 
…osmos#19925)
@dependabot @github-actions @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#…
4b71767 
…19985)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (backport
525b720 
cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <[email protected]>
@mergify @GAtom22
@tac0turtle @julienrbrt
fix(mempool): use no-op mempool as default (backport cosmos#19970) (c…
f76c659 
…osmos#20008)

Co-authored-by: Tom <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @lucaslopezf @julienrbrt
feat: Conditionally emit metrics based on enablement (backport cosmos…
974a24c 
…#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @mmsqe
fix(x/bank): align query with multi denoms for send-enabled (backport c…
452632f 
…osmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <[email protected]>
@mergify @facundomedica
fix: Implement gogoproto customtype to secp256r1 keys (backport cosmo…
521ebe5 
…s#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <[email protected]>
@mergify @mmsqe
fix(client/v2): respect output format from client ctx (backport cosmo…
741b01c 
…s#20033) (cosmos#20046)

Co-authored-by: mmsqe <[email protected]>
@dependabot @github-actions @julienrbrt
build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)
d6a0fa1 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@mergify
feat(x/bank): support depinject for send restrictions (backport cosmo…
dafcc78 
…s#20014) (cosmos#20024)
@mergify
fix(baseapp): don't share global gas meter in tx execution (backport c…
9941498 
…osmos#19616) (cosmos#20050)
@mergify @facundomedica
fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069
49c3ae6 
)

Co-authored-by: Facundo Medica <[email protected]>
@dependabot
build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to…
a2abf1a 
… 1.0.0-beta.5 (cosmos#20095)
@mergify @julienrbrt
feat(client/v2): implement version filtering using annotation (backport
2a32f42 
cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <[email protected]>
@julienrbrt
chore: prepare v0.50.6 (cosmos#19998)
4bd0e02
@mergify @mmsqe
fix: use timestamp for sim log file name (backport cosmos#20108) (cos…
0a682f7 
…mos#20111)

Co-authored-by: mmsqe <[email protected]>
mergify bot and others added 22 commits November 20, 2024 15:33
@mergify @julienrbrt
fix(server): fix fallback genesis path (backport cosmos#22564) (cosmo…
47874ac 
…s#22573)

Co-authored-by: Julien Robert <[email protected]>
@dependabot
build(deps): Bump cosmossdk.io/math from 1.3.0 to 1.4.0 (cosmos#22607)
56c2c7d
@mergify @fastfadingviolets @julienrbrt
fix(client/v2/autocli): prevent duplicate addition of customCommands …
8210b50 
…(backport cosmos#22576) (cosmos#22615)

Co-authored-by: violet <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@dependabot @julienrbrt
build(deps): Bump github.com/cosmos/cosmos-db from 1.0.2 to 1.1.0 (co…
7bb2a3d 
…smos#22638)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@dependabot @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.2.0 to 1.2.2 (cosmos#…
43ac3df 
…22662)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@julienrbrt
chore: prepare v0.50.11 (cosmos#22643)
96a3016
@mergify @JulianToledano @julienrbrt
fix(client/v2/autocli): add CoinDec flag (backport cosmos#22817) (cos…
4a73a1e 
…mos#22821)

Co-authored-by: Julián Toledano <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify
fix(x/tx): fix amino json drift from legacy spec (backport cosmos#21825…
d62bcbd 
…) (cosmos#22088)
@dependabot @julienrbrt
build(deps): Bump cosmossdk.io/x/tx from 0.13.6-0.20241003112805-ff87…
3b082b5 
…89a02871 to 0.13.6 (cosmos#22844)

Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
chore: edit changelog store (partial backport cosmos#22864) (cosmos#2…
679ca5e 
…2884)

Co-authored-by: Julien Robert <[email protected]>
@alpe
Merge commit from fork
ba7ac45 
* Limit recursion depth for unknown field detection

(cherry picked from commit f038dc731c55be1e1c526e67695acc358631afd6)

* Limit unpack any

(cherry picked from commit 1a2bff56fb7391f9ce87d4fbe9e0367ae991c0b2)

* Update Changelog

* Another limit recursion depth for unknown field detection

* Update changelog
@julienrbrt
chore: prep v0.50.11 release notes (cosmos#22898)
eb1a8e8
@dependabot
build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (co…
f465587 
…smos#23030)
@dependabot @julienrbrt
build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0…
9d3c384 
….14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
feat(x/tx): add an option to encode maps using amino json (backport c…
f1b139d 
…osmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)
5f08d21 
Co-authored-by: Julien Robert <[email protected]>
@mergify @alessio
docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)
b9db4d2 
Co-authored-by: Alessio Treglia <[email protected]>
@mergify @julienrbrt
docs: correct explanation on how to set custom signer via depinject (…
effb71f 
…backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <[email protected]>
@mergify @zrbecker
chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)
158f146 
Co-authored-by: Zachary Becker <[email protected]>
@alpe @julienrbrt
Merge commit from fork
9816440 
* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@SpicyLemon
Merge branch 'tag-v0.50.12' into prov/dwedul/bring-in-0.50.12
9377f35 
# Conflicts:
#	RELEASE_NOTES.md
#	baseapp/baseapp.go
#	baseapp/options.go
#	client/v2/CHANGELOG.md
#	client/v2/autocli/query.go
#	client/v2/go.mod
#	client/v2/go.sum
#	go.mod
#	go.sum
#	simapp/go.mod
#	simapp/go.sum
#	tests/go.mod
#	tests/go.sum
#	x/bank/keeper/send.go
#	x/simulation/simulate.go
#	x/tx/CHANGELOG.md
#	x/tx/signing/aminojson/json_marshal.go
#	x/tx/signing/aminojson/json_marshal_test.go
@SpicyLemon
Mark v0.50.12-pio-1 in the changelog.
8c8f9c6
@SpicyLemon SpicyLemon changed the title Prov/dwedul/bring in 0.50.12 Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. Feb 20, 2025
@SpicyLemon
Copy link
Author

SpicyLemon commented Feb 20, 2025

I ran the following make targets locally and they all completed successfully:

  • make test +
  • make test-sim-nondeterminism
  • make test-sim-import-export
  • make test-sim-after-import
  • make test-sim-multi-seed-short

+ The make test command does not indicate any failures, but returns a non-zero exit code. The cosmossdk.io/orm package has some go.sum issues. That's a separate library from the rest of the SDK though. It also doesn't appear to be in use (it doesn't appear in any of the SDK's go.mod files at least). This version (v0.50.12) also deleted a bunch of stuff from there and I wonder if they messed up and meant to delete all of it, but missed. All other tests run and pass.

@SpicyLemon
Copy link
Author

SpicyLemon commented Feb 20, 2025

I also pulled this branch into the Provenance repo and ran make test without issues.

@SpicyLemon
Copy link
Author

SpicyLemon commented Feb 20, 2025 •
edited
Loading

For reference: SDK compare v0.50.11...v0.50.12

@SpicyLemon SpicyLemon merged commit b7c4abd into release-pio/v0.50.x Feb 20, 2025
SpicyLemon added a commit that referenced this pull request Apr 4, 2025
@SpicyLemon @dependabot
@julienrbrt @alessio @zrbecker
Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614)
b07050b 
* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <[email protected]>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <[email protected]>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <[email protected]>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <[email protected]>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Zachary Becker <[email protected]>
SpicyLemon added a commit that referenced this pull request Jul 15, 2025
@SpicyLemon @dependabot
@julienrbrt @alessio @zrbecker @alpe
Remove fee handler and fix post-handler error handling. (#618)
79d1c73 
* Remove the fee handler customization since the SDK added a post handler that does pretty much the same thing.

* Make DefaultGasLimit a variable instead of constant.

* Fix the post handler response code thing.

* Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614)

* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <[email protected]>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <[email protected]>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <[email protected]>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <[email protected]>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Zachary Becker <[email protected]>

* Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#616)

* Improve performance of GetAllBalances and GetAccountsBalances.

* Add changelog entry.

* Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615)

* Merge commit from fork

* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <[email protected]>

* Add changelog entry.

* Put nothing back at the top of the changelog.

---------

Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>

* Add a bunch of logging.

* Revert "Add a bunch of logging."

This reverts commit 3baf4d3.

* Make the DefaultGasLimit a constant again (back to how the SDK has it).

* Add changelog entry.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Zachary Becker <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@SpicyLemon @nullpointer0x00 @tac0turtle @julienrbrt @facundomedica @auricom @alpe