Skip to content

fix for API change in PHP 7.3 #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2018
Merged

fix for API change in PHP 7.3 #4898

merged 1 commit into from
Jul 12, 2018

Conversation

@TeBoring
Copy link
Contributor

@TeBoring TeBoring commented Jul 11, 2018

No description provided.

@TeBoring TeBoring mentioned this pull request Jul 11, 2018
Closed
@xfxyjwf xfxyjwf added the php label Jul 11, 2018
@TeBoring
Copy link
Contributor Author

TeBoring commented Jul 12, 2018

broken tests are not related to this change.

@TeBoring TeBoring merged commit 22503a0 into protocolbuffers:3.6.x Jul 12, 2018
@remicollet remicollet mentioned this pull request Jul 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TeBoring TeBoring

Labels

cla: yes php

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TeBoring @stanley-cheung @googlebot @xfxyjwf