Broken with PHP 7.3.0alpha4

[remicollet]

Build ok since pr #4898 is merged but extension dosn't load (since 7.3.0alpha4, was OK with alpha3)

$ php --no-php-ini --define extension=modules/protobuf.so --modules | grep protobuf

Output is empty. No error message.

P.S. as I can't sign your CLA, I don't plan to work on this issue to propose a fix, so, do it yourself.

[TeBoring]

Where can I get source for 7.3.0alpha4?

[remicollet]

Where can I get source for 7.3.0alpha4?

Sorry, I was probably too fast.
Will be officially announced in a few hours
BTW: https://github.com/php/php-src/releases/tag/php-7.3.0alpha4

[TeBoring]

@remicollet I found the problem is that, in php's main function, zend_startup_modules is called before do_cli (where EG(objects_store) is initialized).

Because protobuf module needs to register well known type messages (which transitively calls zend_class_implements and zend_objects_store_put), it requires EG(objects_store) is initialized first. Is this a bug of php?

[remicollet]

Is this a bug of php?

Don't know... better to ask on internals

[TeBoring]

Sorry, what do you mean by "internals"?

[TeBoring]

There were two suspicious thing:

1. EG(objects_store) was not initialized when registering modules.
2. zend_class_implements transitively calls the creator method of the parent message (in my case, it calls message_create which calls zend_object_std_init)