Extract subdomains in case of 404 #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
requested changes
May 24, 2023
Member
Mzack9999
left a comment
Mzack9999
left a comment
There was a problem hiding this comment.
The issue was potentially extracting from the bottom of the page the 100 suggested names related to the certificate, shown even in case of a 404 error page.
Member
Author
|
@Mzack9999 I see where I went wrong. Do you prefer us to offer assistance with that matter or maintain the current behavior? |
Member
|
We can try to extract the items from the page since we should already have the page body retrieved. |
dogancanbakir
changed the title
Member
Author
|
The cause of the build failure is the source riddler returning a 403 error. It can be temporary so I believe we can ignore it for now. |
Mzack9999
added
the
Type: Enhancement
Mzack9999
approved these changes
May 25, 2023
Member
Mzack9999
left a comment
Mzack9999
left a comment
There was a problem hiding this comment.
lgtm
$ ./subfinder -d allegion.com -s digitorus
...
NF] Enumerating subdomains for allegion.com
notifications-uat.allegion.com
smetrics.allegion.com
startsmart.allegion.com
m3uid01.allegion.com
americas.allegion.com
www.allegion.com
ehsandeep
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #774