Skip to content

Extract subdomains in case of 404 #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2023
Merged

Extract subdomains in case of 404 #845

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5aca90d
Merge pull request #827 from projectdiscovery/dev
ehsandeep May 1, 2023
3741069
output conditional result based on result count
dogancanbakir May 24, 2023
892b6b8
Revert "output conditional result based on result count"
dogancanbakir May 25, 2023
c0828b7
try extracting subdomains from body in case of 404
dogancanbakir May 25, 2023
1c54080
adding doc context to 404 page
Mzack9999 May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion v2/pkg/subscraping/sources/digitorus/digitorus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"bufio"
"context"
"fmt"
"net/http"
"strings"
"time"

Expand All @@ -31,7 +32,8 @@ func (s *Source) Run(ctx context.Context, domain string, session *subscraping.Se
}(time.Now())

resp, err := session.SimpleGet(ctx, fmt.Sprintf("https://certificatedetails.com/%s", domain))
if err != nil {
// the 404 page still contains around 100 subdomains - https://github.com/projectdiscovery/subfinder/issues/774
if err != nil && resp.StatusCode != http.StatusNotFound {
results <- subscraping.Result{Source: s.Name(), Type: subscraping.Error, Error: err}
s.errors++
session.DiscardHTTPResponse(resp)
Expand Down