Skip to content

Conversation

@leonjza
Copy link
Contributor

@leonjza leonjza commented Feb 21, 2024

Proposed changes

This PR is an implementation proposal for #4779, making it possible to further apply issue/tag filters to issue trackers via a new, per tracker allow-list / deny-list options key. This makes it possible to have everything written via an exporter, but only certain issues logged in a tracker.

I wanted to reuse the existing code used for a Filter, but to prevent a cyclic dependency in issue trackers I had to move that out to a new package. Next, I had to extend the Tracker interface to include a ShouldFilter. I don't particularly like this because of the duplicate code, but I am hesitant to change the internal structure too much.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep requested a review from Ice3man543 February 21, 2024 08:57
@olearycrew
Copy link
Contributor

Thanks for this contribution @leonjza - our team will take a look.

@ehsandeep ehsandeep merged commit 3ab0ae6 into projectdiscovery:dev Mar 2, 2024
@ehsandeep ehsandeep linked an issue Mar 2, 2024 that may be closed by this pull request
@ehsandeep ehsandeep modified the milestone: nuclei v3.2.0 Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Issue Tracker Level Filtering

4 participants