fix: prevent package updates when appending channels#5405
Merged
ruben-arts merged 3 commits intoprefix-dev:mainfrom Jan 26, 2026
Merged
fix: prevent package updates when appending channels#5405ruben-arts merged 3 commits intoprefix-dev:mainfrom
ruben-arts merged 3 commits intoprefix-dev:mainfrom
Conversation
116b65d to
2d26685
Compare
ruben-arts
reviewed
Jan 26, 2026
ruben-arts
requested changes
Jan 26, 2026
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
Thank you, this looks good. I would like to make the test faster as this could be slowing down our pipelines.
Contributor
Author
|
Just because I did initially struggle with false positives on this test, I made sure that this test fails on |
When running `pixi workspace channel add`, packages were being unnecessarily re-solved because any channel change was treated as requiring a full re-solve. Due to channel priority semantics, appending channels (lower priority) doesn't affect existing package selections - packages from higher priority channels remain valid. Only prepending, removing, or reordering channels should trigger a re-solve. This change distinguishes between: - ChannelsExtended: channels were appended (packages stay valid) - ChannelsMismatch: channels were changed in other ways (need re-solve) Fixes prefix-dev#5077
8f0b325 to
196becc
Compare
ruben-arts
approved these changes
Jan 26, 2026
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
Thank you, it works for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
pixi workspace channel add, packages were being unnecessarily re-solved because any channel change was treated as requiring a full re-solve.Due to channel priority semantics, appending channels (lower priority) doesn't affect existing package selections - packages from higher priority channels remain valid. Only prepending, removing, or reordering channels should trigger a re-solve.
This change distinguishes between:
Fixes #5077
How Has This Been Tested?
Creating a pixi project to reproduce the scenario:
On a build from this change the pixi.lock is only appending the channel:
as opposed to regular pixi which upgrades python as described in #5077
Checklist: