-
Notifications
You must be signed in to change notification settings - Fork 396
feat: Resolve optional dependencies recursively #3646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resolve optional dependencies recursively #3646
Conversation
d41c693 to
9709fbf
Compare
9709fbf to
32d6c86
Compare
|
Glad to see this might be resolved shortly! ❤️ |
This has now been released in 0.13.6: |
|
Alright. I think this is ready for review. As we now rely on a top-level |
|
@tdejager you may want to give this a look |
6aeb41c to
ea8a258
Compare
24c7473 to
ac17e4b
Compare
ac17e4b to
b939cbf
Compare
tdejager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna be great, found some small changes.
|
@olivier-lacroix I added a test to test the issue from in the test-suite. Do we also need to add recursive depency groups to the the test or do we still rely on the |
|
Also lets run the full suite, added the label. |
Co-authored-by: Tim de Jager <[email protected]>
|
I removed the label, all relevant tests seemed to pass. |
Optional dependencies and dependency groups are managed in the same way by pixi. This to say we can add dependency groups to the test as well :) |
4e268a8 to
a0ac067
Compare
a0ac067 to
2fa6b8a
Compare
|
Thanks @tdejager ! |
Co-authored-by: Tim de Jager <[email protected]>
fixes #2024
This PR depends on PyO3/pyproject-toml-rs#30