Conversation
It seems #280 was just wrong. I didn't test it correctly, and it actually prevented crashes simply because the Vulkan instance failed to create. This failed because it's a device extension, not an instance extension (and we already check for the device extension). The *real* issue seems to be simply the fact this was using the `Instance` after dropping the `Entry`. Which is easy enough to address.
Member
Author
|
The |
calloop executor
5 tasks
Member
Author
|
This should be tested on a Meteor Lake system to make sure the workaround this is for is actually working to prevent graphical corruption (though |
leviport
approved these changes
Mar 13, 2026
Member
leviport
left a comment
There was a problem hiding this comment.
Seems good on MTL darp10, as well as oryp13
mmstick
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems #280 was just wrong. I didn't test it correctly, and it actually prevented crashes simply because the Vulkan instance failed to create.
This failed because it's a device extension, not an instance extension (and we already check for the device extension).
The real issue seems to be simply the fact this was using the
Instanceafter dropping theEntry. Which is easy enough to address.