backend/wayland/vulkan: Enable VK_EXT_physical_device_drm extension#280
Merged
backend/wayland/vulkan: Enable VK_EXT_physical_device_drm extension#280
VK_EXT_physical_device_drm extension#280Conversation
Fixes a segfault when run with `--no-default-features` to disable `wgpu`.
leviport
approved these changes
Feb 6, 2026
mmstick
approved these changes
Feb 12, 2026
ids1024
added a commit
that referenced
this pull request
Mar 12, 2026
It seems #280 was just wrong. I didn't test it correctly, and it actually prevented crashes simply because the Vulkan instance failed to create. This failed because it's a device extension, not an instance extension (and we already check for the device extension). The *real* issue seems to be simply the fact this was using the `Instance` after dropping the `Entry`. Which is easy enough to address.
This was referenced Mar 13, 2026
mmstick
pushed a commit
that referenced
this pull request
Mar 13, 2026
It seems #280 was just wrong. I didn't test it correctly, and it actually prevented crashes simply because the Vulkan instance failed to create. This failed because it's a device extension, not an instance extension (and we already check for the device extension). The *real* issue seems to be simply the fact this was using the `Instance` after dropping the `Entry`. Which is easy enough to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a segfault when run with
--no-default-featuresto disablewgpu.This doesn't seem to change anything when built normally, but it seems like a good idea to do this correctly. I think the very simple Vulkan code here should otherwise be correct.