image-copy: Do not panic on ImageCaptureSourceKind::Destroyed#2190
Open
image-copy: Do not panic on ImageCaptureSourceKind::Destroyed#2190
ImageCaptureSourceKind::Destroyed#2190Conversation
The way this was handled previously is incorrect. We should still handle creation of a capture session, just send `stopped` when it is created. This can be tested by creating a capture source and session for a workspace that has been removed. Toplevel and output sources have a different issue in `smithay`: Smithay/smithay#1961 Should fix pop-os/cosmic-epoch#3319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way this was handled previously is incorrect. We should still handle creation of a capture session, just send
stoppedwhen it is created.This can be tested by creating a capture source and session for a workspace that has been removed. Toplevel and output sources have a different issue in
smithay: Smithay/smithay#1961Should fix pop-os/cosmic-epoch#3319.
https://gist.github.com/ids1024/808358ed4671af7a8b31edc97a45cccc has a minimal test client using
cosmic-client-toolkitto reproduce the issue; by trying to create a capture session for a workspace as soon as it is removed. Prior to this PR, that crashed the compositor when a workspace is removed. After it, the compositor runs fine, and that shows the capture session isstopped.