WIP image-capture-source: Don't send error on closed output/toplevel#1961
Draft
ids1024 wants to merge 1 commit intoSmithay:masterfrom
Draft
WIP image-capture-source: Don't send error on closed output/toplevel#1961ids1024 wants to merge 1 commit intoSmithay:masterfrom
ids1024 wants to merge 1 commit intoSmithay:masterfrom
Conversation
I believe these tests are inherently racy, so we can't be sending a protocol error. Instead this should work, but creating a capture session should immediately result in a `stopped` event. Should we have an alternative to `output_source_created` and `toplevel_source_created` that is called when a source is created with this? (To add any user data the compositor expects, etc.) Or should we just document that the compositor shouldn't assume either of these have been called?
ids1024
added a commit
to pop-os/cosmic-comp
that referenced
this pull request
Mar 12, 2026
The way this was handled previously is incorrect. We should still handle creation of a capture session, just send `stopped` when it is created. This can be tested by creating a capture source and session for a workspace that has been removed. Toplevel and output sources have a different issue in `smithay`: Smithay/smithay#1961 Should fix pop-os/cosmic-epoch#3319.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe these tests are inherently racy, so we can't be sending a protocol error.
Instead this should work, but creating a capture session should immediately result in a
stoppedevent.Should we have an alternative to
output_source_createdandtoplevel_source_createdthat is called when a source is created with this? (To add any user data the compositor expects, etc.) Or should we just document that the compositor shouldn't assume either of these have been called?Checklist
[x] I agree to smithay's Developer Certificate of Origin.