Skip to content

Add storage weight reclaim to Kusama system chains#941

Merged
fellowship-merge-bot[bot] merged 21 commits intomainfrom
skunert/enable-reclaim
Nov 25, 2025
Merged

Add storage weight reclaim to Kusama system chains#941
fellowship-merge-bot[bot] merged 21 commits intomainfrom
skunert/enable-reclaim

Conversation

@skunert
Copy link
Copy Markdown
Contributor

@skunert skunert commented Oct 1, 2025

This PR adds weight reclaim to Kusama system chains. Part of #494.

Originally we were hoping for quick fixing of paritytech/polkadot-sdk#6020, but it has proven to be quite tricky. The risk of overshooting in reality is low though, since we still have configurable training wheels in place (PoV size capped at 80% by default).

@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Oct 2, 2025

/cmd fmt

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Command "fmt" has started 🚀 See logs here

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Command "fmt" has finished ✅ See logs here

@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Oct 2, 2025

/cmd bench --runtime asset-hub-kusama bridge-hub-kusama coretime-kusama --pallet cumulus_pallet_weight_reclaim

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Command "bench --runtime asset-hub-kusama bridge-hub-kusama coretime-kusama --pallet cumulus_pallet_weight_reclaim" has started 🚀 See logs here

… bridge-hub-kusama coretime-kusama --pallet cumulus_pallet_weight_reclaim'
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Command "bench --runtime asset-hub-kusama bridge-hub-kusama coretime-kusama --pallet cumulus_pallet_weight_reclaim" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 289.21us Added
system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 12.40us Added
system-parachains/asset-hubs/asset-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 21.11us Added

@skunert skunert marked this pull request as ready for review October 6, 2025 08:00
@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Oct 9, 2025

/cmd bench --runtime people-kusama --pallet cumulus_pallet_weight_reclaim

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Command "bench --runtime people-kusama --pallet cumulus_pallet_weight_reclaim" has started 🚀 See logs here

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

Command "bench --runtime people-kusama --pallet cumulus_pallet_weight_reclaim" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/people/people-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 11.18us Added
system-parachains/coretime/coretime-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 289.21us Added
system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 12.40us Added
system-parachains/asset-hubs/asset-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 21.11us Added

@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Oct 10, 2025

/cmd bench --runtime coretime-kusama encointer-kusama --pallet cumulus_pallet_weight_reclaim

@github-actions
Copy link
Copy Markdown

Command "bench --runtime coretime-kusama encointer-kusama --pallet cumulus_pallet_weight_reclaim" has started 🚀 See logs here

…encointer-kusama --pallet cumulus_pallet_weight_reclaim'
@github-actions
Copy link
Copy Markdown

Command "bench --runtime coretime-kusama encointer-kusama --pallet cumulus_pallet_weight_reclaim" has finished ✅ See logs here

Details

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/people/people-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 11.18us Added
system-parachains/encointer/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 11.17us Added
system-parachains/coretime/coretime-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 11.79us Added
system-parachains/bridge-hubs/bridge-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 12.40us Added
system-parachains/asset-hubs/asset-hub-kusama/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 21.11us Added

@bkchr
Copy link
Copy Markdown
Contributor

bkchr commented Oct 13, 2025

Before this can be merged, we need to backport this to some of the stable releases. Otherwise the state_traceBlock rpc breaks and this is being used by indexers like subscan.

@skunert and me already discussed on how to backport this pull request. He will handle it.

@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Nov 12, 2025

/cmd fmt

@skunert
Copy link
Copy Markdown
Contributor Author

skunert commented Nov 12, 2025

@bkchr With paritytech/polkadot-sdk#10221 and paritytech/polkadot-sdk#10208 merged, I think we are ready to go here.

@skunert skunert requested a review from acatangiu November 12, 2025 18:25
@github-actions
Copy link
Copy Markdown

Command "fmt" has started 🚀 See logs here

@github-actions
Copy link
Copy Markdown

Command "fmt" has finished ✅ See logs here

@acatangiu
Copy link
Copy Markdown
Contributor

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 638be95 into main Nov 25, 2025
53 of 67 checks passed
@fellowship-merge-bot
Copy link
Copy Markdown
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants