EIP 3607 - Prevent transaction from non-EOA account#905
Merged
sorpaas merged 2 commits intopolkadot-evm:masterfrom Dec 1, 2022
Merged
EIP 3607 - Prevent transaction from non-EOA account#905sorpaas merged 2 commits intopolkadot-evm:masterfrom
sorpaas merged 2 commits intopolkadot-evm:masterfrom
Conversation
sorpaas
approved these changes
Dec 1, 2022
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
* add EIP 3607 check * tests
Collaborator
Member
|
Its EIP status is already "Final" so I believe it's already on-chain (or is it Shanghai upgrade?) Anyway, I think it mostly shouldn't matter -- this EIP is mostly security precautions. In practice, EOA never has code (if it has then something is wrong). We can also add config options to disable this EIP if you really need it. |
Collaborator
|
I just found that some behaviours of the frontier compatibility layer are not consistent with geth.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-3607
I extended the logic to also prevent transactions from precompiles, as projects like Moonbeam have precompiles that interacts with other contracts which will expect calls from precompiles to be legitimate.