Conversation
nbaztec
added
B7-runtimenoteworthy
notlesh
reviewed
Feb 9, 2023
notlesh
reviewed
Feb 9, 2023
notlesh
approved these changes
Feb 9, 2023
Contributor
notlesh
left a comment
notlesh
left a comment
There was a problem hiding this comment.
Looks good to me. I'm somewhere between pleasantly surprised and skeptical that our Frontier patches are so minimal...
tgmichel
added
the
A10-evmtracing
tgmichel
reviewed
Feb 10, 2023
| RandomnessCollectiveFlip: pallet_randomness_collective_flip::{Pallet, Storage} = 2, | ||
| Timestamp: pallet_timestamp::{Pallet, Call, Storage, Inherent} = 3, | ||
| ParachainInfo: parachain_info::{Pallet, Storage, Config} = 4, | ||
| RootTesting: pallet_root_testing::{Pallet, Call, Storage} = 5, |
Contributor
There was a problem hiding this comment.
Are we positive index 5 was never used?
Contributor
Author
There was a problem hiding this comment.
Good question, I can move it to end of line just to be safe. @notlesh opinions?
Collaborator
|
--sealing manual doesn't work because it uses the wrong parent hash it seems: |
This was referenced Feb 11, 2023
Collaborator
|
🥇 |
notlesh
added
D1-audited👍
notlesh
added
D5-nicetohaveaudit⚠️
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* upgrade to v0.9.37 * fix tests * update frontier * fix tests * add root-testing pallet * add call_index * Fix tracing reference hash --------- Co-authored-by: tgmichel <telmo@purestake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
upgrades moonbeam to v0.9.37
Notes
Substrate
Pallet Assets
destroy()in favor offreeze_asset(),start_destroy(),destroy_accounts(),destroy_approvals()andfinish_destroy().AssetDetailsnew fieldstatusin lieu ofis_frozen.DestroyWitnessparameter.RemoveItemsLimitto config.moonbeam.CreateOriginto Assets Pallet paritytech/substrate#12586CreateOriginmoonbeam.CallbackHandlemoonbeam.AssetIdresulting from the removal ofHasCompacttrait boundAssetIdParametermoonbeam.Inherents
InherentDataProvider::create_inherent_data()is nowasyncnimbus.InherentDataProvider::provide_inherent_data()is nowasyncnimbus.Others
#[pallet::call_index]attribute to dispatchables.pallet_balancesitemInactiveIssuance.pallet_balanceswas missing to set the storage_version attribute for the Pallet struct. Besides that it also removes the old StorageVersion representation.pallet_balancesstorage itemStorageVersion.root_testingpallet paritytech/substrate#12451system.fillBlock()topallet-root-testingPolkadot
ParaGenesisArgsfieldparachain: boolby enum fieldpara_kind: ParaKindxcm_mocksmoonbeam.Cumulus
ParachainBlockImportnow includesBlockandBackendparametersnimbus.sc-networkparitytech/substrate#12764SharedImportQueuein favor ofImportQueueService.nimbus.Nimbus
Frontier
Refactor
BlockId::Numberin favor ofBlockId::Hashparitytech/polkadot-sdk#53
Backend::StorageProviderProofProviderFinalizerBlockIdremoval: refactor:HeaderBackend::headerparitytech/substrate#12874HeaderBackend::status|headerBlockBackend::block|block_statusBackend::justificationsOthers
rpc_binary_search_estimate=>rpc-binary-search-estimateMoonbeam
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?