Fix eth_getTransactionReceipt race condition#1802
Merged
librelois merged 20 commits intopolkadot-evm:masterfrom Feb 3, 2026
Merged
Fix eth_getTransactionReceipt race condition#1802librelois merged 20 commits intopolkadot-evm:masterfrom
eth_getTransactionReceipt race condition#1802librelois merged 20 commits intopolkadot-evm:masterfrom
Conversation
manuelmauro
force-pushed
the
manuel/fix-receipt-race-condition
branch
from
ba8c8fd to
5d7e6f0
Compare
manuelmauro
force-pushed
the
manuel/fix-receipt-race-condition
branch
from
5d7e6f0 to
105efa2
Compare
ethers.js v6 caches eth_getTransactionCount responses at the provider level. When multiple tests run sequentially using the same signer, subsequent tests may receive stale cached nonces instead of making fresh RPC calls. This fixes the "nonce has already been used" test failures by: - Using direct RPC calls (context.ethersjs.send) to bypass caching - Explicitly setting nonces in transactions to ensure correctness The backend changes to latest_block_hash() use mapping-sync as the source of truth for consistency with other RPCs. When the best block isn't indexed yet, it falls back to the latest indexed block.
Member
|
@sorpaas we would appreciate to have your feedback on this PR, can you take a look? Thanks |
librelois
requested changes
Feb 2, 2026
Member
librelois
left a comment
librelois
left a comment
There was a problem hiding this comment.
Missing Database Migration
The diff adds a new column BLOCK_NUMBER_MAPPING = 4 and changes NUM_COLUMNS from 4 to 5, but upgrade.rs still shows:
CURRENT_VERSION: u32 = 2
V2_NUM_COLUMNS: u32 = 4
Existing databases won't have column 4 populated for already-synced blocks. After an upgrade, historical blocks won't be queryable via eth_getBlockByNumber until re-synced from scratch. A migration from version 2 to version 3 should be added to backfill the block_number -> ethereum_block_hash mapping.
librelois
reviewed
Feb 2, 2026
librelois
reviewed
Feb 2, 2026
librelois
reviewed
Feb 2, 2026
librelois
reviewed
Feb 2, 2026
Contributor
Author
Added KV store migration in 091f2ae |
librelois
reviewed
Feb 3, 2026
librelois
reviewed
Feb 3, 2026
librelois
reviewed
Feb 3, 2026
librelois
approved these changes
Feb 3, 2026
manuelmauro
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Feb 3, 2026
* test: 🧪 add TDD failing test
* refactor: ♻️ use mapping-sync as single source of truth for eth_ RPCs
* fix: 🐛 fix missing args
* test: ✅ redefine waitForBlock as a polling function
* style: 🎨 fmt
* fix: 🐛 wait for the right block number
* revert: 🔥 remove temporary delay
* chore: 📦 update package lock
* test: ✅ update test timeouts
* test: ✅ remove explicit nonce to fix EIP-7702 test race condition
* fix: bypass ethers.js nonce caching in EIP-7702 tests
ethers.js v6 caches eth_getTransactionCount responses at the provider
level. When multiple tests run sequentially using the same signer,
subsequent tests may receive stale cached nonces instead of making
fresh RPC calls.
This fixes the "nonce has already been used" test failures by:
- Using direct RPC calls (context.ethersjs.send) to bypass caching
- Explicitly setting nonces in transactions to ensure correctness
The backend changes to latest_block_hash() use mapping-sync as the
source of truth for consistency with other RPCs. When the best block
isn't indexed yet, it falls back to the latest indexed block.
* fix: 🐛 verify mapped blocks against canonical chain during reorgs
* revert: 🔥 remove LATEST_INDEXED_BLOCK
* fix: 🐛 correctly error instead of defaulting to block number 0
* fix: 🐛 verify all non-genesis blocks
* test: ✅ add error handling to waitForBlock
* fix: 🐛 use consistent behavior for eth_getBlockByNumber("latest") on SQL backend
* feat: ✨ add KV store migration
* fix: 🐛 do not default to 0
* feat: 🔊 log processed entries in parity db migration
manuelmauro
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Feb 3, 2026
* test: 🧪 add TDD failing test
* refactor: ♻️ use mapping-sync as single source of truth for eth_ RPCs
* fix: 🐛 fix missing args
* test: ✅ redefine waitForBlock as a polling function
* style: 🎨 fmt
* fix: 🐛 wait for the right block number
* revert: 🔥 remove temporary delay
* chore: 📦 update package lock
* test: ✅ update test timeouts
* test: ✅ remove explicit nonce to fix EIP-7702 test race condition
* fix: bypass ethers.js nonce caching in EIP-7702 tests
ethers.js v6 caches eth_getTransactionCount responses at the provider
level. When multiple tests run sequentially using the same signer,
subsequent tests may receive stale cached nonces instead of making
fresh RPC calls.
This fixes the "nonce has already been used" test failures by:
- Using direct RPC calls (context.ethersjs.send) to bypass caching
- Explicitly setting nonces in transactions to ensure correctness
The backend changes to latest_block_hash() use mapping-sync as the
source of truth for consistency with other RPCs. When the best block
isn't indexed yet, it falls back to the latest indexed block.
* fix: 🐛 verify mapped blocks against canonical chain during reorgs
* revert: 🔥 remove LATEST_INDEXED_BLOCK
* fix: 🐛 correctly error instead of defaulting to block number 0
* fix: 🐛 verify all non-genesis blocks
* test: ✅ add error handling to waitForBlock
* fix: 🐛 use consistent behavior for eth_getBlockByNumber("latest") on SQL backend
* feat: ✨ add KV store migration
* fix: 🐛 do not default to 0
* feat: 🔊 log processed entries in parity db migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users report intermittent issues where
eth_getTransactionReceiptreturns null immediately after getting a transaction hash frometh_getBlockByNumber. This happens because:eth_getBlockByNumberreads from runtime storage (available immediately after block import)eth_getTransactionReceiptreads from themapping-syncdatabase (delayed until worker processes the block)Solution
Rely on
mapping-syncstorage for all impacted RPCs.Changes
ts-tests/tests/test-receipt-consistency.ts: Integration tests for receipt consistencyTesting
The TDD commit includes an artificial 2-second delay in
mapping-syncto reliably reproduce the race condition. Remove before merging.