Integrate Frontier's fix for eth_getTransactionReceipt race condition

[manuelmauro]

What does it do?

Integrate Frontier's fix for eth_getTransactionReceipt race condition: polkadot-evm/frontier#1802

[coderabbitai]

Walkthrough

This PR adds block retrieval by number to the lazy-loading backend and RPC client layers, and introduces a retry-enabled test helper function for more resilient block fetching. The helper is then integrated across multiple test suites to replace direct block fetch calls.

Changes

Cohort / File(s)	Summary
Backend & RPC Implementation node/service/src/lazy_loading/frontier_backend.rs, node/service/src/lazy_loading/rpc_client.rs	Added block_hash_by_number method to LazyLoadingFrontierBackend and block_by_number method to RPC client for fetching blocks by number, mirroring existing block-by-hash patterns and error handling.
Test Helper test/helpers/eth-transactions.ts	Added getBlockWithRetry helper function with configurable retry logic (maxAttempts, delayMs) supporting retrieval by blockHash, blockNumber, or latest block, with error handling for BlockNotFoundError scenarios.
Test Suite Updates test/suites/dev/moonbase/test-chain/test-fork-chain.ts, test/suites/dev/moonbase/test-txpool/test-txpool-limits*.ts	Replaced direct context.viem().getBlock() calls with getBlockWithRetry(context) for improved resilience against transient block retrieval failures across multiple test files.

Sequence Diagram

sequenceDiagram
    participant Test
    participant Helper as getBlockWithRetry
    participant RPC Client
    participant Backend
    
    Test->>Helper: getBlockWithRetry(context, options)
    Helper->>RPC Client: block_by_number(blockNumber)
    RPC Client->>Backend: block_by_number(blockNumber)
    Backend->>RPC Client: Result<Option<H256>, String>
    RPC Client->>Helper: Result<Option<Block>>
    alt BlockNotFoundError or timeout
        Helper->>Helper: Wait delayMs
        Helper->>RPC Client: Retry (until maxAttempts)
    else Success
        Helper->>Test: Return Block
    end
    Test->>Test: Assert block properties

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 By number now the blocks do flow,
Through RPC's retry magic, swift and slow,
With gentle pauses 'tween each try,
The tests dance on, they'll never die! 🌟

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references 'eth_getTransactionReceipt' and 'race condition', but the changes focus on implementing 'block_hash_by_number' and 'getBlockWithRetry' for block retrieval. While these may be part of fixing the race condition, the title doesn't clearly describe the actual code changes.	Update the title to better reflect the main changes, such as 'Implement block_hash_by_number and add getBlockWithRetry helper' or a more specific description of the Frontier integration work being done.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch manuel/fix-race-condition-in-frontier-rpc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2120 KB (no changes) ✅

Moonbeam runtime: 2236 KB (no changes) ✅

Moonriver runtime: 2236 KB (no changes) ✅

Compared to latest release (runtime-4102)

Moonbase runtime: 2120 KB (+184 KB compared to latest release) ⚠️

Moonbeam runtime: 2236 KB (+200 KB compared to latest release) ⚠️

Moonriver runtime: 2236 KB (+204 KB compared to latest release) ⚠️