Skip to content

feat: Support descendingly-sorted values in search_sorted()#22825

Merged
coastalwhite merged 5 commits intopola-rs:mainfrom
itamarst:22821-support-ascending-in-search-sorted
May 23, 2025
Merged

feat: Support descendingly-sorted values in search_sorted()#22825
coastalwhite merged 5 commits intopola-rs:mainfrom
itamarst:22821-support-ascending-in-search-sorted

Conversation

@itamarst
Copy link
Copy Markdown
Contributor

@itamarst itamarst commented May 19, 2025

Fixes #22821

Split out of #22633

@itamarst itamarst changed the title feat(python, rust): Support descendingly-sorted values in search_sorted() feat: Support descendingly-sorted values in search_sorted() May 19, 2025
@github-actions github-actions Bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels May 19, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.69%. Comparing base (d9195d5) to head (1fcedd2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../polars-python/src/lazyframe/visitor/expr_nodes.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22825      +/-   ##
==========================================
- Coverage   80.69%   80.69%   -0.01%     
==========================================
  Files        1671     1671              
  Lines      221268   221284      +16     
  Branches     2791     2791              
==========================================
+ Hits       178551   178560       +9     
- Misses      42052    42059       +7     
  Partials      665      665              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@itamarst itamarst marked this pull request as ready for review May 19, 2025 16:31
@coastalwhite
Copy link
Copy Markdown
Collaborator

We should wait with this until the release is out.

@coastalwhite coastalwhite force-pushed the 22821-support-ascending-in-search-sorted branch from 614cf77 to 1fcedd2 Compare May 23, 2025 07:14
@coastalwhite coastalwhite merged commit 5bff877 into pola-rs:main May 23, 2025
28 checks passed
@itamarst itamarst deleted the 22821-support-ascending-in-search-sorted branch May 23, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search_sorted() doesn't expose search for case where descending=True

3 participants