Skip to content

[Persistence] Adds TreeStore logger#852

Merged
dylanlott merged 1 commit intomainfrom
tree-store-logger
Jun 27, 2023
Merged

[Persistence] Adds TreeStore logger#852
dylanlott merged 1 commit intomainfrom
tree-store-logger

Conversation

@dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jun 22, 2023 •
edited
Loading

Description

  • [Persistence] Adds a logger to TreeStore module

Issue

Enabled by changes introduced in #756 and #808

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Adds a logger to the tree store

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@reviewpad reviewpad bot added the medium Pull request is medium label Jun 22, 2023
@dylanlott dylanlott changed the title Adds TreeStore logger [WIP] Adds TreeStore logger Jun 22, 2023
@dylanlott dylanlott changed the base branch from main to tree-store-module June 22, 2023 20:09
@reviewpad reviewpad bot added small Pull request is small and removed medium Pull request is medium labels Jun 22, 2023
@dylanlott dylanlott force-pushed the tree-store-logger branch from e729a3e to 88507a1 Compare June 22, 2023 20:24
@dylanlott dylanlott self-assigned this Jun 22, 2023
@dylanlott dylanlott force-pushed the tree-store-logger branch from 88507a1 to 320ef16 Compare June 27, 2023 00:42
@reviewpad reviewpad bot added large Pull request is large and removed small Pull request is small labels Jun 27, 2023
@dylanlott dylanlott changed the base branch from tree-store-module to main June 27, 2023 00:46
@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jun 27, 2023
@dylanlott dylanlott changed the title [WIP] Adds TreeStore logger [Persistence] Adds TreeStore logger Jun 27, 2023
@dylanlott dylanlott marked this pull request as ready for review June 27, 2023 00:47
@dylanlott dylanlott added the e2e-devnet-test Runs E2E tests on devnet label Jun 27, 2023
@dylanlott dylanlott requested review from Olshansk and h5law June 27, 2023 00:52
@dylanlott dylanlott merged commit 95cee08 into main Jun 27, 2023
@dylanlott dylanlott deleted the tree-store-logger branch June 27, 2023 01:45
bryanchriswhite added a commit that referenced this pull request Jun 28, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into refactor/unicast-router
904f17b 
* pokt/main:
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  [Persistence] Change root hash calculation to use an SMT (#843)
bryanchriswhite added a commit that referenced this pull request Jun 28, 2023
@bryanchriswhite
Merge branch 'refactor/unicast-router' into feat/integrate-bg-router
70b020b 
* refactor/unicast-router:
  fix: return error
  chore: cleanup unused garbage
  chore: add missing godoc comments
  chore: add submodule TECHDEBT comments
  chore: comment cleanup
  chore: cleanup unused test utils
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  [Persistence] Change root hash calculation to use an SMT (#843)
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge branch 'feat/integrate-bg-router' into chore/introduce-submodule
3ce4953 
* feat/integrate-bg-router: (21 commits)
  chore: improve comment'
  wip: docs: architecture diagrams
  chore: add TECHDEBT comment
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
  chore: return early
  chore: improve debug logging
  chore: improve comments
  chore: improve variable naming
  fix: `p2pModule#Send()` routing logic
  fix: interim background router bootstrapping
  chore: router logging improvements
  fix: return error
  chore: cleanup unused garbage
  chore: add missing godoc comments
  chore: add submodule TECHDEBT comments
  chore: comment cleanup
  chore: cleanup unused test utils
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  ...
bryanchriswhite added a commit that referenced this pull request Jun 29, 2023
@bryanchriswhite
Merge branch 'feat/integrate-bg-router' (early part) into chore/intro…
90fe9c4 
…duce-submodule

* 'feat/integrate-bg-router' (early part): (21 commits)
  test: fix raintree message target test
  [P2P] refactor: unicast router (#844)
  chore: add TECHDEBT comment
  Update E2E_FEATURE_LIST.md
  Update vault_test.go (#862)
  chore: return early
  chore: improve debug logging
  chore: improve comments
  chore: improve variable naming
  fix: `p2pModule#Send()` routing logic
  fix: interim background router bootstrapping
  chore: router logging improvements
  fix: return error
  chore: cleanup unused garbage
  chore: add missing godoc comments
  chore: add submodule TECHDEBT comments
  chore: comment cleanup
  chore: cleanup unused test utils
  [IBC] Create initial IBC module (#842)
  [Persistence] Adds TreeStore logger (#852)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Olshansk Olshansk Olshansk approved these changes

@h5law h5law Awaiting requested review from h5law

Assignees

@dylanlott dylanlott

Labels

e2e-devnet-test Runs E2E tests on devnet small Pull request is small waiting-for-review

Projects

V1 Dashboard
Status: Done

Milestone

M1: Pocket PoS (Proof of Stake)

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanlott @Olshansk