Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 31.52% 31.44% -0.08%
==========================================
Files 107 110 +3
Lines 9034 9190 +156
==========================================
+ Hits 2848 2890 +42
- Misses 5846 5955 +109
- Partials 340 345 +5
☔ View full report in Codecov by Sentry. |
20 tasks
| - [Node Configuration](#node-configuration) | ||
| - [Components](#components) | ||
| - [ICS-24 Host Requirements](#ics-24-host-requirements) | ||
|
|
Collaborator
There was a problem hiding this comment.
Wdyt about adding a persistence (or something) section which covers what network state this module interacts with?
Contributor
Author
There was a problem hiding this comment.
I have added a brief section to cover this but the rest of the persistence info will come in the ICS-24 Store PR as this is where interfacing with persistence actually comes into play
20 tasks
Olshansk
requested changes
Jun 22, 2023
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
h5law
force-pushed
the
ibc/initial_module
branch
from
22b48dd to
d1a4667
Compare
Olshansk
reviewed
Jun 26, 2023
| option go_package = "github.com/pokt-network/pocket/runtime/configs"; | ||
|
|
||
| message IBCConfig { | ||
| // If IBC is enabled by a node there are two possible states depending on the |
Olshansk
reviewed
Jun 26, 2023
| f.Add("port") | ||
| } | ||
| } | ||
| f.Fuzz(func(t *testing.T, idType string) { |
Olshansk
reviewed
Jun 26, 2023
| @@ -0,0 +1,24 @@ | |||
| package host | |||
Collaborator
There was a problem hiding this comment.
Thank you for splitting these into separate files!
Makes it so much easier to read and understand!
Olshansk
approved these changes
Jun 26, 2023
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
@h5law I know you didn't re-request a review on this but I took another look and thing it's more than good enough.
There are probably some changes we can make, but I don't think anything is a blocker so let's merge it in and iterate on main.
bryanchriswhite
added a commit
that referenced
this pull request
Jun 28, 2023
* refactor/unicast-router: fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) [Persistence] Change root hash calculation to use an SMT (#843)
bryanchriswhite
added a commit
that referenced
this pull request
Jun 29, 2023
* feat/integrate-bg-router: (21 commits) chore: improve comment' wip: docs: architecture diagrams chore: add TECHDEBT comment Update E2E_FEATURE_LIST.md Update vault_test.go (#862) chore: return early chore: improve debug logging chore: improve comments chore: improve variable naming fix: `p2pModule#Send()` routing logic fix: interim background router bootstrapping chore: router logging improvements fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) ...
bryanchriswhite
added a commit
that referenced
this pull request
Jun 29, 2023
…duce-submodule * 'feat/integrate-bg-router' (early part): (21 commits) test: fix raintree message target test [P2P] refactor: unicast router (#844) chore: add TECHDEBT comment Update E2E_FEATURE_LIST.md Update vault_test.go (#862) chore: return early chore: improve debug logging chore: improve comments chore: improve variable naming fix: `p2pModule#Send()` routing logic fix: interim background router bootstrapping chore: router logging improvements fix: return error chore: cleanup unused garbage chore: add missing godoc comments chore: add submodule TECHDEBT comments chore: comment cleanup chore: cleanup unused test utils [IBC] Create initial IBC module (#842) [Persistence] Adds TreeStore logger (#852) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the base IBC module and partially implements ICS-24 (paths, keys and identifiers)
Issue
Fixes #794
Type of change
Please mark the relevant option(s):
List of changes
shared/modules/ibc_module.goshared/core/types/commitments.gofor IBC commitment type aliasesshareds/core/types/errors.goTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)