Skip to content

[General] Ignore false positive secret uncovered by ggshield on main #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Olshansk merged 4 commits into from
Jun 20, 2023
Merged

[General] Ignore false positive secret uncovered by ggshield on main #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a6fa6a
Ignore secrets and introduce make comments related to ggshield
Olshansk Jun 20, 2023
f06d3db
Update Makefile
Olshansk Jun 20, 2023
5d40120
Update comment in ggshield_secrets_add
Olshansk Jun 20, 2023
d335ce5
Make gitguardian path relative
Olshansk Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitguardian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
secret:
ignored-matches:
- match: d1585b49ffa864bfb76b2432b26933a866c3cf621a9d5dd41690c1568edd85ed
name: Generic High Entropy Secret - charts/pocket/templates/configmap-genesis.yaml
version: 2
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,6 @@ tools/wiki

# ignore highest precedence config file read by default
/config.json

# ggshield
.cache_ggshield
8 changes: 8 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,3 +573,11 @@ search_interfaces: ## Greps and outputs all of the structs in the project (exclu
.PHONY: search_protos
search_protos: ## Finds all of the proto files in the project (excluding vendor)
find . -name "*.proto" -not -path "./vendor/*"

.PHONY: ggshield_secrets_scan
ggshield_secrets_scan: ## Scans the project for secrets using ggshield
ggshield secret scan path --recursive .

.PHONY: ggshield_secrets_add
ggshield_secrets_add: ## A helper that adds the last results from `make ggshield_secrets_scan`, store in `.cache_ggshield` to `.gitguardian.yaml`. See `ggshield for more configuratiosn`
ggshield secret ignore --last-found