[General] Ignore false positive secret uncovered by ggshield on main#848
Merged
[General] Ignore false positive secret uncovered by ggshield on main#848
ggshield on main#848Conversation
Olshansk
added
core
adshmh
reviewed
Jun 20, 2023
Contributor
adshmh
left a comment
adshmh
left a comment
There was a problem hiding this comment.
Not sure if the comments I have added should be blockers, so added them all as review comments.
Co-authored-by: Arash <23505281+adshmh@users.noreply.github.com>
20 tasks
adshmh
approved these changes
Jun 20, 2023
okdas
approved these changes
Jun 20, 2023
dylanlott
pushed a commit
that referenced
this pull request
Jun 21, 2023
#848) ## Description <!-- reviewpad:summarize:start --> ### Summary generated by Reviewpad on 20 Jun 23 22:06 UTC This pull request includes changes to add .gitguardian.yaml file to ignore secrets and gitignore patterns for ggshield. There are also updates to the Makefile to include new targets for ggshield to scan and ignore secrets, as well as an update to make the path relative in the .gitguardian.yaml file. <!-- reviewpad:summarize:end --> ## Issue NA ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [x] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Added `ggshiled` helpers to scan and ignore secrets in the future - Ignoring a secret that was introduced by #827 that was blocking main seen [here](https://github.com/pokt-network/pocket/pull/803/checks?check_run_id=14359233756) -  ## Testing CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 20 Jun 23 22:06 UTC
This pull request includes changes to add .gitguardian.yaml file to ignore secrets and gitignore patterns for ggshield. There are also updates to the Makefile to include new targets for ggshield to scan and ignore secrets, as well as an update to make the path relative in the .gitguardian.yaml file.
Issue
NA
Type of change
Please mark the relevant option(s):
List of changes
ggshiledhelpers to scan and ignore secrets in the futureTesting
NA