-
Notifications
You must be signed in to change notification settings - Fork 33
[Infra] Fullnode on LocalNet #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
2cb95e2
6445368
3c27279
bbd3ce4
58185c4
877b5fc
35eb743
d433a41
03eb150
9812aa5
c94cfa1
d7541bf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.0.0.42] - 2023-05-12 | ||
|
|
||
| - Added private keys for all (except fisherman) actors | ||
| - Changed the debug_keybase package to support multiple yaml secrets in one yaml file | ||
| - Added full node (non-staked validator) | ||
|
|
||
| ## [0.0.0.41] - 2023-05-08 | ||
|
|
||
| - Updated Dockerfiles using outdated go version to 1.19 | ||
|
|
||
|
|
||
| ## [0.0.0.40] - 2023-05-04 | ||
|
|
||
| - Added `network_id` parameter to the node config files | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Overall, the patch seems to be updating the changelog with developments made in the project. Below are some suggestions and potential risk factors:
Improvement Suggestion: If these private keys are meant for testing purposes only, clarify this in the changelog or remove them entirely and use a more secure method for handling private keys, such as environment variables or secret management tools.
For example:
It would be helpful to have access to the actual code changes to provide a more detailed review, but based on the information provided in the submitted patch, these are the primary concerns and suggestions. |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a brief code review of the provided patch:
The patch adds a new version (0.0.0.42) to the changelog with the date
2023-05-12.The changes include:
debug_keybasepackage to support multiple YAML secrets in one YAML filePotential issues and suggestions:
Storing private keys directly in the code base can be a security risk. Consider using a secure key management system or environment variables to avoid exposing sensitive information.
It is unclear if there are any access control mechanisms if the private keys are visible in the project. Make sure to implement proper access control to prevent unauthorized use of the keys.
Regarding the
debug_keybasechange, ensure proper parsing and validation of the multiple YAML secrets. This can help minimize potential bugs or vulnerabilities when handling the new format.For the newly added full node, thoroughly test its integration with the existing architecture to confirm proper functioning and detect any compatibility issues or edge cases.