-
Notifications
You must be signed in to change notification settings - Fork 33
[Infra] Fullnode on LocalNet #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2cb95e2
--wip-- [skip ci]
okdas 6445368
--wip-- [skip ci]
okdas 3c27279
Merge branch 'main' into fullnode-localnet
okdas bbd3ce4
added private keys for other actors
okdas 58185c4
add changelog
okdas 877b5fc
Merge branch 'main' into fullnode-localnet
okdas 35eb743
change date
okdas d433a41
remove private-keys-misc
okdas 03eb150
req changes
okdas 9812aa5
Merge branch 'main' into fullnode-localnet
okdas c94cfa1
change changelog date
okdas d7541bf
remove extra tr
okdas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a brief code review of the provided patch:
The patch adds a new version (0.0.0.42) to the changelog with the date
2023-05-12.The changes include:
debug_keybasepackage to support multiple YAML secrets in one YAML filePotential issues and suggestions:
Storing private keys directly in the code base can be a security risk. Consider using a secure key management system or environment variables to avoid exposing sensitive information.
It is unclear if there are any access control mechanisms if the private keys are visible in the project. Make sure to implement proper access control to prevent unauthorized use of the keys.
Regarding the
debug_keybasechange, ensure proper parsing and validation of the multiple YAML secrets. This can help minimize potential bugs or vulnerabilities when handling the new format.For the newly added full node, thoroughly test its integration with the existing architecture to confirm proper functioning and detect any compatibility issues or edge cases.