[P2P] test: URL conversion with mockdns#586
Merged
bryanchriswhite merged 5 commits intomainfrom Mar 15, 2023
Merged
Conversation
bryanchriswhite
changed the title
bryanchriswhite
force-pushed
the
test/mockdns
branch
from
04fea55 to
5440e33
Compare
deblasis
reviewed
Mar 15, 2023
deblasis
reviewed
Mar 15, 2023
deblasis
reviewed
Mar 15, 2023
| quadARecord dnsRecordType = "AAAA" | ||
| ) | ||
|
|
||
| func prepareDNSResolverMock(t *testing.T, zones map[string]mockdns.Zone) (done func()) { |
deblasis
reviewed
Mar 15, 2023
Contributor
deblasis
left a comment
deblasis
left a comment
There was a problem hiding this comment.
Nice one @bryanchriswhite !
I wonder if the mockDNS change could also solve the issue #584
At a glance, it sounds like it might be a quick win. Wdyt?
Collaborator
Author
|
@deblasis Thanks for calling out that issue, I hadn't see it yet. 🙌 I think it would be best to tackle that one in a separate PR. I don't think it's as straightforward as adding another usage of mockdns. |
bryanchriswhite
added a commit
that referenced
this pull request
Mar 16, 2023
* pokt/main: [P2P] test: URL conversion with mockdns (#586) Create devlog4.md Update devlog3.md to remove demo Create devlog3.md [CLI] add private keys embed to debug cli build (#578) [Documentation] Fix SLIP Master Key and Child Key diagrams to be in the correct order (#573) add get secrets perms to cluster-manager-account service account (#572)
Olshansk
reviewed
Mar 17, 2023
| @@ -173,33 +182,134 @@ func TestServiceURLFromLibp2pMultiaddr_Error(t *testing.T) { | |||
|
|
|||
| // TECHDEBT: add helpers for crating and/or using a "test resolver" which can | |||
Collaborator
There was a problem hiding this comment.
Should we remove this comment?
| quadARecord dnsRecordType = "AAAA" | ||
| ) | ||
|
|
||
| func prepareDNSResolverMock(t *testing.T, zones map[string]mockdns.Zone) (done func()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was a
TECHDEBTitem that became trivial to do as work progressed on another task which also required use ofmockdns(#576).Issue
Not related to any specific issue.
Type of change
Please mark the relevant option(s):
List of changes
mockdnsas a test dependencyurl_conversion_test.gourl_conversion_test.gofor single- and multi-record DNS responsesTesting
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)