add get secrets perms to cluster-manager-account service account#572
Merged
add get secrets perms to cluster-manager-account service account#572
Conversation
okdas
added
infra
deblasis
approved these changes
Mar 9, 2023
Contributor
deblasis
left a comment
deblasis
left a comment
There was a problem hiding this comment.
Oh, interesting, it looks like I must have missed a commit or something. 🤦♂️
Nice catch!
LGTM 🚀
bryanchriswhite
added a commit
that referenced
this pull request
Mar 16, 2023
* pokt/main: [P2P] test: URL conversion with mockdns (#586) Create devlog4.md Update devlog3.md to remove demo Create devlog3.md [CLI] add private keys embed to debug cli build (#578) [Documentation] Fix SLIP Master Key and Child Key diagrams to be in the correct order (#573) add get secrets perms to cluster-manager-account service account (#572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows cluster-manager to get
v1-localnet-validators-private-keyssecret.Issue
Cluster manager complained about inability to access private keys secret when ran localnet from scratch.
Type of change
Please mark the relevant option(s):
List of changes
cluster-manager-accountservice account to an existing bindingTesting
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)