[Tooling] Returning failed tests full output#542
Merged
Conversation
Contributor
Author
|
Outputting the results of failed tests: test_outputs.mp4 |
Collaborator
|
@deblasis Per my comment in discord, do you think it's possible to aggregate the outputs for one failing test in one output field? |
Contributor
Author
I basically obtained the initial output with some jq and bash |
okdas
approved these changes
Feb 23, 2023
Contributor
okdas
left a comment
There was a problem hiding this comment.
I love this, thank you for this change! It makes sense to include the whole stack of error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR updated our Github workflow to return the full output of failed tests for easier debugging/troubleshooting.
It was raised by @bryanchriswhite here:
#534 (comment)
And also probably related:
Issue
Type of change
Please mark the relevant option(s):
List of changes
jq🪄 to return all the rows that match a failed testTesting
make develop_testREADMERequired Checklist
If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)